Reimplement month diff logic #2133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ichernev
force-pushed
the
fix-month-diff
branch
from
7f75902
to
45d7736
Compare
The new algorithm to compute month differences between two moments (used in `diff(a, 'month|quarter|year')`), is as follows: - take the whole number of months between the two dates (ignoring day-of-month and hour) -- whole-month-diff - the above is adjusted by how much the second date is away from the whole-month-diff-date (the date where the result would be exactly whole-month-diff) This algorithm makes sure that dates that are exact number of months apart would return whole numbers (like previous algorithm), but also fixes a few edge cases that the old agorithm failed to do, like when the first moment is close to the end of a long month and the second moment was in the begining of a short month (end of Jan to begining of Feb for example). Fixes moment#2026
ichernev
force-pushed
the
fix-month-diff
branch
from
45d7736
to
ae83a69
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new algorithm to compute month differences between two moments (used in
diff(a, 'month|quarter|year')), is as follows:and hour) --
wholeMonthDiffwhole-month-diff-date (the date where the result would be exactly
wholeMonthDiff)This algorithm makes sure that dates that are exact number of months apart
would return whole numbers (like previous algorithm), but also fixes a few edge
cases that the old agorithm failed to do, like when the first moment is close
to the end of a long month and the second moment was in the begining of a short
month (end of Jan to begining of Feb for example).
Fixes #2026