Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[misc] TS: Add specs & tests for moment.RFC_2822 #4034

Closed
wants to merge 1 commit into from
Closed

[misc] TS: Add specs & tests for moment.RFC_2822 #4034

wants to merge 1 commit into from

Conversation

ovangle
Copy link
Contributor

@ovangle ovangle commented Jun 24, 2017 •
edited

Not much to say, the typescript declaration wasn't added when RFC_2822 parsing was added in 2.18.

Fixes #4033

@TracyGJG
Copy link
Contributor

TracyGJG commented Jul 9, 2017

Resolved by PR #3940 update.

@ovangle
Copy link
Contributor Author

ovangle commented Jul 9, 2017

This isn't actually resolved by #3940, this is a separate issue. #3940 adds in the declaration for the toRFC2822String method to the moment prototype, this adds in the declaration of the RFC_2822 constant.

@ichernev ichernev changed the title Add typescript declaration for moment.RFC_2822 [misc] TS: Add specs & tests for moment.RFC_2822 Aug 3, 2017
@ichernev
Copy link
Contributor

ichernev commented Aug 7, 2017

Merged in 20a0db6

@ichernev ichernev closed this Aug 7, 2017
ichernev added a commit that referenced this pull request Aug 7, 2017
@ichernev
Merge pull request #4034 from ovangle:fix/4033
20a0db6 
[misc] TS: Add specs & tests for moment.RFC_2822
@ovangle ovangle mentioned this pull request Aug 9, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Pending Next Release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ovangle @TracyGJG @ichernev