[bugfix] remove ordinal for Turkish locale as they use `cardin…
#4361
Conversation
|
|
alan-agius4
force-pushed
the
feature/tr-local-ordinal
branch
from
3430f30
to
e63f09d
Compare
alan-agius4
changed the title
ordinal for Turkish locale as they use `cardin…ordinal for Turkish locale as they use `cardin…
alan-agius4
changed the title
ordinal for Turkish locale as they use `cardin…ordinal for Turkish locale as they use `cardin…
…inal` days Closes: moment#4122
alan-agius4
force-pushed
the
feature/tr-local-ordinal
branch
from
e63f09d
to
86225de
Compare
alan-agius4
changed the title
ordinal for Turkish locale as they use `cardin…ordinal for Turkish locale as they use `cardin…
|
@BYK - can you review this? It's unclear if we should keep the Turkish ordinals in the codebase at all (this PR removes them entirely). |
marwahaha
added
locale approval needed
Pending Next Release
and removed
Pending Next Release
labels
src/test/locale/tr.js
Outdated
| ['h hh', '3 03'], | ||
| ['H HH', '15 15'], | ||
| ['m mm', '25 25'], | ||
| ['s ss', '50 50'], | ||
| ['a A', 'pm PM'], | ||
| ['[yılın] DDDo [günü]', 'yılın 45\'inci günü'], | ||
| ['[yılın] DDDo [günü]', 'yılın 45 günü'], |
There was a problem hiding this comment.
This is incorrect. The old test is correct and we should keep that.
There was a problem hiding this comment.
is this the only spec that should be kept?
There was a problem hiding this comment.
As mentioned in the original issue earlier, one never uses "December 3rd", it is always "3 December" or rarely, "December 3". Ordinals are only used when you are saying something like "The 3rd week of the year", "The 5th day of the month" (this one actually uses a slightly different thing than ordinals but ordinals are also fine) or "the first Sunday of March".
There was a problem hiding this comment.
Did some further changes, can you re-check please? I am not sure if I covered everything.
|
@alan-agius4 - could you add a couple tests specific to the issue you're fixing? @BYK - could you review again? |
|
I actually amended the existing test to match the new behaviour for some dates |
Turkish don't use ordinal days but rather cardinals
#4122 (comment)