Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

how about locale with zh-mo? #4827

Closed
chi-gao opened this issue Oct 21, 2018 · 2 comments
Closed

how about locale with zh-mo? #4827

chi-gao opened this issue Oct 21, 2018 · 2 comments

Comments

@chi-gao
Copy link

chi-gao commented Oct 21, 2018

Description of the Issue and Steps to Reproduce:
I find the locales files without zh-mo in v2.22.2.

If you are reporting an issue, please run the following code in the environment you are using and include the output:

console.log( (new Date()).toString())
console.log((new Date()).toLocaleString())
console.log( (new Date()).getTimezoneOffset())
console.log( navigator.userAgent)
console.log(moment.version)
'Sun Oct 21 2018 21:40:30 GMT+0800 (中国标准时间)'
'2018/10/21 下午9:40:30'
'-480'
"Mozilla/5.0 (Windows NT 10.0; WOW64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/70.0.3538.67 'Safari/537.36'"
'2.22.2'
@marwahaha
Copy link
Member

Hi @garygao12580 , if you would like to add zh-mo, please follow
https://github.com/moment/moment/blob/develop/CONTRIBUTING.md

and do

Copy the file src/locale/en-gb.js (or similar) into a new file src/locale/zh-mo.js. Translate everything into zh-mo.
Copy the file src/test/locale/en-gb.js into a new file src/test/locale/zh-mo.js. Translate everything into zh-mo.
Go to the command line, navigate to this project, and run grunt. All the tests should pass.

@marwahaha marwahaha mentioned this issue Jan 17, 2019
6 tasks
@marwahaha
Copy link
Member

closing as part of #4949

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants