[bugfix] Inconsistent moment(object) behaviour when using day: 0 (#5097) #5098
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jnelssonsmith
changed the title
|
@marwahaha if you could have a squiz at this when you get a chance that would be great 💯 |
|
Or @ichernev @troyastorino 😄 |
|
@ichernev @jnelssonsmith Is it possible to at least include this as breaking change in the changelog somehow? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As explained in issue #5097 this fixes a bug where
moment({day: 0})was acting differently fromday: '0',date: 0ordate: '0'. This is ultimately due to the use ofi.day || i.date. Wheni.dayis 0, it is still falsey so it returnsi.datewhich is undefined.This PR makes the behaviour consistent by explicitly checking whether the key is undefined rather than just falsey.