Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bugfix] moment#5327 output wrong next week in ja locale #5329

Merged
merged 2 commits into from Apr 23, 2020

Conversation

terrencewtk
Copy link
Contributor

Fix the issue #5327.

@terrencewtk terrencewtk changed the title fix: moment#5327 output wrong next week in ja locale bugfix: moment#5327 output wrong next week in ja locale Dec 28, 2019
@terrencewtk terrencewtk changed the title bugfix: moment#5327 output wrong next week in ja locale [bugfix] moment#5327 output wrong next week in ja locale Dec 28, 2019
@coveralls
Copy link

coveralls commented Dec 28, 2019

Coverage Status

Coverage remained the same at 88.41% when pulling 58b5fe5 on terrencew97:fix/wrong-next-week-in-ja-locale into 13a61b2 on moment:develop.

@ulion
Copy link
Contributor

ulion commented Apr 19, 2020

should the other similar place in the code be fixed?

@terrencewtk
Copy link
Contributor Author

should the other similar place in the code be fixed?

I did a global search before and seems only ja has this problem.

@ulion
Copy link
Contributor

ulion commented Apr 20, 2020 via email

@terrencewtk
Copy link
Contributor Author

I mean, in the ja locale file, there is the other similar place need to do this fix. Terrence Wong notifications@github.com 于2020年4月20日周一 下午9:22写道:

should the other similar place in the code be fixed? I did a global search before and seems only ja has this problem. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#5329 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AABKYHO2T3ZLTFXQOFTP5NLRNRECNANCNFSM4KAIOMWQ .
-- Ulion

you are right, I have added it in the new commit.

@ichernev ichernev merged commit ff30dbe into moment:develop Apr 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants