Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation for startOf incorrect #813

Closed
shellscape opened this issue May 30, 2013 · 2 comments
Closed

Documentation for startOf incorrect #813

shellscape opened this issue May 30, 2013 · 2 comments

Comments

@shellscape
Copy link

Documentation states that startOf('week') is available in 1.7.0 when it is definitely not available. The weekday function doesn't exist in the 1.7.0 series and it is critical for startOf('week') to do it's thing.

The documentation should be updated to accurately display which features are available in which versions. This isn't the first time I've run across this problem. I've tweeted at the twitter account about this with no reply.

@timrwood
Copy link
Member

Thanks for the heads up.

startOf('week') was added some time after the other startOf() units were added, so it must have slipped by me when writing the docs. I opened an issue on the momentjs.com repo to update the docs. moment/momentjs.com#39

For most open source projects, it's probably better to open an issue on github than to mention it on twitter. Tweets can get lost more easily than github issues, and github issues allow for a more appropriate amount of discussion than 140 characters.

@icambron
Copy link
Member

Fixed in moment/momentjs.com#39

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants