Bug: fromNow() gives the wrong result for invalid number

[alexewerlof]

What is the bug?

> var j = moment(NaN)
undefined
> j.fromNow()
"a few seconds ago"
> j.calendar()
"Invalid date"

Why is it a bug?

1. Inconsistency (calendar() correctly detects that this date is invalid but fromNow() blindly spit out results
2. Probability. In our case we parse an angular attribute like this: moment(Number(attrs.epoch)) and instead of saying "Invalid date" it says "a few seconds ago".

version : 2.8.3

[mattgrande]

Counter-point: Calling isValid() correctly returns false, so that should be all that matters. You should expect to see incorrect data when using an invalid date, and it should be up to the developer to handle that.

I agree it "feels" wrong, though... Perhaps the fromNow() method could return "Invalid date" if isValid() is false?

[alexewerlof]

Perhaps the fromNow() method could return "Invalid date" if isValid() is false?

That would be great.

[donaldpcook]

Added a pull request if this is the route that we want to go