fix: topics subscription resiliency #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cprice404
reviewed
Dec 27, 2023
| } | ||
| case TopicSubscribeError(): | ||
| print("Subscribe error: ${sub.errorCode} ${sub.message}"); | ||
| } | ||
|
|
||
| // unsubscribing should not affect the topic client's ability |
There was a problem hiding this comment.
this is really useful, I imagine it was great as almost a TDD approach to working on this feature. In the long run though, we probably want to keep these examples as simple as humanly possible, so we might want to move this to an "advanced topics example" or something.
Not in any way, shape, or form a blocker for this PR :) just calling it out as something to be aware of for future touching up on these examples/docs and stuff.
cprice404
reviewed
Dec 27, 2023
| @@ -30,6 +70,10 @@ class TopicSubscription implements TopicSubscribeResponse { | |||
| } | |||
| return null; | |||
| } | |||
|
|
|||
| void unsubscribe() async { | |||
| await _stream.cancel(); | |||
cprice404
approved these changes
Dec 27, 2023
| @@ -21,7 +23,7 @@ class TopicClient implements ITopicClient { | |||
| TopicClient( | |||
| CredentialProvider credentialProvider, TopicConfiguration configuration) | |||
| : _pubsubClient = ClientPubsub(credentialProvider, configuration) { | |||
| _logger.level = determineLoggerLevel(configuration.logLevel); | |||
| // _logger.level = determineLoggerLevel(configuration.logLevel); | |||
There was a problem hiding this comment.
errant comments, maybe remove in a later PR.
|
|
||
| @override | ||
| void close() { | ||
| _pubsubClient.close(); |
|
cc @bruuuuuuuce merging it now but we should loop back and test it more thoroughly |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
addresses #27
if subscription was not cancelled explicitly using the
unsubscribemethod on theTopicSubscriptionclass, the topic client will attempt to re-establish a connection.adds a grpc manager class for the topic client so we can easily extend the internal topic client to use multiple grpc connections in the future if needed.
manually tested and confirmed that:
unsubscribewill cancel the subscription and still allow the topic client to subscribe to a topic afterwards