Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

>100 subscriptions will hang program #55

Closed
anitarua opened this issue Jan 3, 2024 · 3 comments
Closed

>100 subscriptions will hang program #55

anitarua opened this issue Jan 3, 2024 · 3 comments
Assignees
Labels
dart for dart sdk

Comments

@anitarua
Copy link
Collaborator

anitarua commented Jan 3, 2024

topic client on the surface appears to allow >100 subscriptions, but actually trying to get messages from the 101st subscription causes the program to hang (shows no published messages or errors)

quick googling results seemed like dart grpc might not have config for setting the maximum number of concurrent streams, or it might be named something else and will require more research

@anitarua anitarua added the dart for dart sdk label Jan 3, 2024
@cprice404
Copy link

@anitarua we will need to have a config option to open multiple grpc channels in order to handle this case. probably similar to what we did in the golang client.

@anitarua anitarua self-assigned this Jan 4, 2024
@anitarua
Copy link
Collaborator Author

anitarua commented Jan 4, 2024

not sure if we really need the multiple grpc channels config yet. I think I'll just try to make the sdk return a TopicSubscribeError if the channels are maxed out or otherwise receives an error while getting the first element

@cprice404
Copy link

agreed, we don't need to add the multiple channels support yet. and actually I think it's okay to keep this as an open issue for now; I'm not aware of anyone with immediate plans to do that many subscriptions from a single device.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dart for dart sdk
Projects
None yet
Development

No branches or pull requests

2 participants