Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: error responses should print informative errors by default #88

Merged
merged 2 commits into from
Jan 9, 2024
Merged

chore: error responses should print informative errors by default #88

merged 2 commits into from
Jan 9, 2024

Conversation

anitarua
Copy link
Collaborator

@anitarua anitarua commented Jan 9, 2024 •
edited

addresses #68

Before, print(getResp) would print Instance of 'GetError' and now it’ll print [MomentoErrorCode.invalidArgumentError] Invalid cache name

Makes use of Dart's Exception class which has a toString method that's used to print exceptions.

pgautier404
pgautier404 approved these changes Jan 9, 2024
View reviewed changes
Copy link
Contributor

@pgautier404 pgautier404 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks!

@anitarua anitarua merged commit b04ba43 into main Jan 9, 2024
2 checks passed
@anitarua anitarua deleted the print-errors branch January 9, 2024 23:33
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pgautier404 pgautier404 pgautier404 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@anitarua @pgautier404