Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misc tweaks #41

Merged
merged 10 commits into from Nov 2, 2022
Merged

Misc tweaks #41

merged 10 commits into from Nov 2, 2022

Conversation

tsa96
Copy link
Member

@tsa96 tsa96 commented Oct 24, 2022

This is a bit of a bits-and-bobs PR I'm afraid, loads of small fixes I wanted to get in ASAP.

Closes #25
Closed #23

@tsa96 tsa96 force-pushed the feat/misc-tweaks branch 2 times, most recently from f8a99d9 to a3c6b4c Compare October 24, 2022 17:57
@tsa96
Copy link
Member Author

tsa96 commented Oct 24, 2022

Reordered some of this to also do #23

scripts/mainmenu_mapselector.js Outdated Show resolved Hide resolved
scripts/mainmenu_mapselector.js Outdated Show resolved Hide resolved
scripts/mainmenu_mapselector.js Outdated Show resolved Hide resolved
scripts/mainmenu_mapselector.js Outdated Show resolved Hide resolved
Various small tweaks, and switches to the updates Gamemodes structure
This isn't a serious fix since brae's planning on rewritten this stuff anyway, but should make JS errors disappear for now
I *think* Valve have fixed this already and we've pulled it in from csgo, since the graph seems scaled wrong for everyone now. So I'm 90% sure this'll fix everything.
@tsa96
Copy link
Member Author

tsa96 commented Oct 26, 2022

Got rid of the debug Msgs and changed the .some to a negated .every which I think is a lot clearer

scripts/hud/cgaz.js Outdated Show resolved Hide resolved
Tried to get as close to what Goc asked for in #23
This fixes an issue with panel IDs bugging out because the shortName was used as an ID and Pano doesn't like it containing a hash
@Gocnak Gocnak merged commit a6ef1c3 into master Nov 2, 2022
@Gocnak Gocnak deleted the feat/misc-tweaks branch November 2, 2022 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename enum types to CamelCase Create better mapping for GameModes for easier comparisons
3 participants