Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AbstractService: Replace mcrypt_encrypt/decrypt calls with their openssl counterparts #3

Closed
xplodwild opened this issue Feb 22, 2017 · 2 comments
Assignees

Comments

@xplodwild
Copy link
Contributor

In AbstractService.php around line 677 to 733, the methods mcrypt_encrypt and mcrypt_decrypt are deprecated.

The mcrypt PHP module is deprecated as of PHP 7.1 and will be removed in PHP 7.2. See the PHP 7.1 deprecation article for more information. The mcrypt library has been in an abandoned state for over a decade, and thus might present security issues in the future.

It is advised to use the OpenSSL equivalent, openssl_encrypt and openssl_decrypt.

@eurodude
Copy link

eurodude commented May 2, 2017

This is an interesting task as the chosen algorithm is not mappable to openssl algortithm (MCRYPT_RIJNDAEL_256). So all the data exported will not be compatible with the new version.

However, importing in the old version of a file, then upgrading MONARC, then exporting again should work fine to "port" the files.

@eurodude eurodude self-assigned this May 2, 2017
@eurodude
Copy link

eurodude commented May 2, 2017

The issue has been resolved

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants