Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AbstractService: Move the risk calculations methods into a separate helper class #2

Closed
xplodwild opened this issue Feb 22, 2017 · 1 comment

Comments

@xplodwild
Copy link
Contributor

In AbstractService.php around line 677 to 733, the risk calculation methods are directly put as methods.

This doesn't make sense as they are used only in a limited set of services, and should be moved into a separate (helper) class as static methods, as they don't require a specific state nor a specific entity.

@ghost ghost self-assigned this Mar 7, 2017
@ghost
Copy link

ghost commented Mar 7, 2017

Create a trait for risks calculation methods

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant