Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Tabs - line of active tab is under expected position #1992

Closed
ramarm opened this issue Mar 4, 2024 · 2 comments
Closed

[Bug]: Tabs - line of active tab is under expected position #1992

ramarm opened this issue Mar 4, 2024 · 2 comments
Labels
bug Something isn't working

Comments

@ramarm
Copy link

ramarm commented Mar 4, 2024

Vibe version

2.93.0

Describe the bug

When using the TabList component, the blue line is under the expected position. You can see in the attached video.

Expected behavior

The line should be 8 px above 4px margin in top + bottom.

Steps to reproduce

Just use the TabList. You can see that the inner tag have 4px padding in my environment while in the playground it is 0.

Reproduction example link

https://www.loom.com/share/a2c457044b444fda9d5a340f6d215f24?sid=76cec034-b9ab-4ea4-a1a1-8000c3f3c571

System Info

Chrome version 122, windows 11

Additional context, Screenshots

No response

@ramarm ramarm added the bug Something isn't working label Mar 4, 2024
@ramarm
Copy link
Author

ramarm commented Mar 17, 2024

Hey @talkor
This but is also fixed when adding * { box-sizing: border-box; }
Thanks

@YossiSaadi
Copy link
Contributor

@ramarm Thanks for reporting!
linking those issues to each other and resolving them for now
we're discussing whether we should export the library with default box-sizing or not, but anyway this is a breaking change and would only occur in next major

related #2001

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants