Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

report the operator version as part of the last state object #674

Closed
vjeffrey opened this issue Nov 10, 2022 · 2 comments · Fixed by #675
Closed

report the operator version as part of the last state object #674

vjeffrey opened this issue Nov 10, 2022 · 2 comments · Fixed by #675

Comments

@vjeffrey
Copy link

What is not working as you expected it?

Version: version.Version,

in this part of the code, the version reported (operator version) should be moved into the last state object

@imilchev
Copy link
Member

That Version field seems to be exactly for reporting the agent version. Do we want to report the operator version in the state and here or do we simply move the version to the last state?

@vjeffrey
Copy link
Author

oh, nice catch, actually we should probably have both the client version and the operator version, both in the laststate object.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants