Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tries to write log files to the location of the executable #194

Closed
iamsmooth opened this issue Dec 5, 2014 · 8 comments
Closed

tries to write log files to the location of the executable #194

iamsmooth opened this issue Dec 5, 2014 · 8 comments

Comments

@iamsmooth
Copy link
Contributor

simplewallet (and maybe bitmonerod?) uses the location of the executable to store the log files. This might be normal for Windows, but is clearly broken for linux (where executable would normally go in some non-writeable bin) and probably mac too.

In the case of simplewallet it is reasonable for the log file to go the same place as the wallet file. bitmonerod might write its log file into .bitmonero although a package manager build should probably go to a standard log location, so there should be a build option for this.

@sammy007
Copy link

sammy007 commented Dec 5, 2014

I'd like to suggest naming pattern: /wallet/file/location/{wallet_file_name}.log

@tewinget
Copy link
Contributor

tewinget commented Dec 5, 2014

For nix my goto is /var/log/

As for Windows, not sure what the default is...

At any rate, very valid point(s). Thanks.
On Dec 5, 2014 12:29 AM, "Sammy Libre" notifications@github.com wrote:

I'd like to suggest naming pattern:
/wallet/file/location/{wallet_file_name}.log


Reply to this email directly or view it on GitHub
#194 (comment)
.

@iamsmooth
Copy link
Contributor Author

/var/log certainly makes sense for bitmonerod, although for simplewallet there is something to be said for sammy's suggestion, since it is a user app and not a system app, plus that is the only way to get a history of transactions performed. No matter what though, putting it with the bin is definitely wrong for linux

@netmonk
Copy link

netmonk commented Dec 5, 2014

would be interesting to add a --log-file options when running multiples instances on the same machine

@iamsmooth
Copy link
Contributor Author

Yes there should definitely be a log-file option. My earlier comments were about where the default should go.

@netmonk
Copy link

netmonk commented Dec 5, 2014

/var/log sounds good :)

@netmonk
Copy link

netmonk commented Dec 5, 2014

but should use syslog facility, to deal with write permission in /var/log.
So option should be provided to target which facility to use in syslog.

Or the make install under root, should deal with file creation in /var/log and setting correct permission for running bitmonerod without root priviledges

@fluffypony
Copy link
Contributor

I believe this is fixed now with the latest batch of merges.

stoffu pushed a commit to stoffu/monero that referenced this issue Sep 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants