New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
0MQ IPC and monero-rpc-deprecated #393
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… to non-OOP nature of net_skeleton
As the core RPC server is being redone to use ZeroMQ and the legacy RPC is being wrapped around that, RPC IP and Port args still need to stick around for the daemon's remote invocation. This will likely change in the near future.
Needs testing to make sure everything works (insofar as it already did on this branch), but it builds. Conflicts: external/CMakeLists.txt src/daemon/CMakeLists.txt src/daemon/daemon.cpp src/wallet/wallet2.h
merged into development |
scilicet64
pushed a commit
to Beldex-Coin/beldex
that referenced
this pull request
Mar 20, 2019
Actually use get_last_block_header function Tweak some values
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A bunch of intermittent communication failures after the rebase. Otherwise, I think it works fine.
Things to be done: