Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QR code overlaps GUI on Trezor T display #2960

Closed
bosomt opened this issue Jun 17, 2020 · 9 comments
Closed

QR code overlaps GUI on Trezor T display #2960

bosomt opened this issue Jun 17, 2020 · 9 comments

Comments

@bosomt
Copy link

bosomt commented Jun 17, 2020

software: Monero GUI 0.16.0.0
hardware: Trezor model T fw version 2.3.1
OS: windows 10 , latest version

How to reproduce:

  1. go to receive tam
  2. press Show on device
  3. device freezes, application freezes

image

@xiphon
Copy link
Collaborator

xiphon commented Jun 17, 2020

@ph4r05

@rating89us
Copy link
Contributor

rating89us commented Jun 17, 2020

I'm using Trezor FW 2.3.0 in Monero GUI 0.16.0.0 and I can tap on the buttons below the QR code, but it is really difficult because they are covered.
If I remember correctly, in previous Trezor FW versions you could tap on the QR code to make it disappear.

@ph4r05
Copy link
Contributor

ph4r05 commented Jun 17, 2020

@rating89us I've just tested it and had similar results. Due to the limited space, it is more problematic to hit the button but I succeeded. So I hope it is not a blocker issue, but it is not good for UX for sure.

I don't think we can scale down the QR code much because it could become unreadable. QR codes for monero addresses are bigger compared to the currencies the QR code was deployed for (e.g., BTC).

So the question is how it should be handled properly...

@rating89us
Copy link
Contributor

rating89us commented Jun 17, 2020

It would be better if the QR code were moved down and the bottom buttons hidden while QR code is shown. This would give enough space for the path on top to be displayed.

Tapping or swipping the QR code should make it disappear.

Like this:
image

@ph4r05
Copy link
Contributor

ph4r05 commented Jun 17, 2020

@rating89us hmm I like the idea that swipe/tap removes the QR code!

@rating89us
Copy link
Contributor

I also noticed that the screen of @bosomt's device is a little larger than the screen of my Trezor Model T. Maybe older versions of Model T had a different screen with lower touch sensitivity on the borders.

@tsusanka
Copy link

tsusanka commented Jun 27, 2020

@rating89us @ph4r05 have you ever used this feature? I mean the fact that Trezor is capable of showing the QR code. Because I have not and it seems to me as a feature for 0.01% users. So I am actually wondering if we should not remove the QR code completely. What is your take on that?

@tsusanka
Copy link

tsusanka commented Jul 1, 2020

Fixed on our side in firmware, trezor/trezor-firmware@0f9a245. The fix will be most likely included in the next firmware 2.3.2 to be released on August 5th.

Feel free to close this issue.

@selsta
Copy link
Collaborator

selsta commented Jul 1, 2020

@tsusanka Thank you for the update, closing.

@selsta selsta closed this as completed Jul 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants