Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Windows build broken by #3170 #3296

Closed
iDunk5400 opened this issue Feb 19, 2018 · 4 comments
Closed

Windows build broken by #3170 #3296

iDunk5400 opened this issue Feb 19, 2018 · 4 comments
Labels
resolved

Comments

@iDunk5400
Copy link
Contributor

Since #3170 was merged, building in MSYS2 fails like this:
https://build.getmonero.org/builders/monero-static-win64/builds/3757/steps/compile/logs/stdio

I managed to make it build by substituting command_line::has_arg with !command_line::is_not_defaulted here, but I think it's better the author fix any code or template issues properly. (@mrwhythat)
@danrmiller danrmiller mentioned this issue Feb 26, 2018
Closed
@stoffu stoffu mentioned this issue Feb 26, 2018
Closed
@stoffu
Copy link
Contributor

stoffu commented Feb 26, 2018

#3318

@iDunk5400
Copy link
Contributor Author

#3318 does fix the build failure. Thanks.

@moneromooo-monero
Copy link
Collaborator

+resolved

@rodentrabies
Copy link
Contributor

@stoffy, thanks for fixing this for me. Sorry I couldn't respond in time, as I don't have any Windows machines at hand.

This was referenced Mar 30, 2018
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
resolved
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@rodentrabies @moneromooo-monero @iDunk5400 @stoffu @issue-helper