Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[seraphis] performance_tests: framework updates #8659

Merged
merged 1 commit into from Jun 27, 2023

Conversation

UkoeHB
Copy link
Contributor

@UkoeHB UkoeHB commented Dec 1, 2022

This is a PR in my 'upstreaming seraphis_lib project', the changes here are not used anywhere yet.

  • Allow custom parameter packs for tests. This enables changing parameters programmatically and reduces the number of test templates you need to compile.
  • Improve error reporting for failed tests.

Future work

  • TimingsDatabase improvements to better enable recording test results in a csv format.

@UkoeHB UkoeHB changed the title performance_tests: framework updates [seraphis] performance_tests: framework updates Dec 12, 2022
@moneromooo-monero
Copy link
Collaborator

I do not see the point of this patch. Could you expand ?
At a push, the return value change might help in reproducing a failure quicker (if there was a per loop random seed, which I do not think there is atm), but the rest seems gratuitous. What am I missing ?

@UkoeHB
Copy link
Contributor Author

UkoeHB commented Dec 15, 2022

@moneromooo-monero I need these changes to support the big seraphis perf tests:
https://github.com/UkoeHB/monero/blob/seraphis_lib/tests/performance_tests/seraphis_tx.h
https://github.com/UkoeHB/monero/blob/31a518f7db7dca3150acf4e3427b535e1d1943f8/tests/performance_tests/main.cpp#L247

Improved error reporting is just the - FAILED ON INIT and - FAILED ON LOOP stuff. Knowing which loop helps debug random vs non-random failures.

@luigi1111 luigi1111 merged commit feb7fa4 into monero-project:master Jun 27, 2023
@UkoeHB UkoeHB deleted the perf_framework_update branch June 28, 2023 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants