Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set priority appears broken #9221

Closed
selsta opened this issue Mar 8, 2024 · 3 comments · Fixed by #9219
Closed

set priority appears broken #9221

selsta opened this issue Mar 8, 2024 · 3 comments · Fixed by #9219

Comments

@selsta
Copy link
Collaborator

selsta commented Mar 8, 2024

[wallet 431t1S]: set priority 2
Wallet password: 
[wallet 431t1S]: set
priority = 2 (normal)
[wallet 431t1S]: address
0  431t1SuHXJNE3U5GhqoGCw2t5XpAZRwyX2h3AfG5BKzkZuYWrVaEyyRdHGaXUMLhiCAc5mF5EaLN9cqie64a5PA3TXTiw3g  Primary address (used)
[wallet 431t1S]: transfer 431t1S 0.01
Wallet password: 
There is currently a 37 block backlog at that fee level. Is this okay?  (Y/Yes/N/No): n
Error: transaction cancelled.
@SChernykh
Copy link
Contributor

It happens because of this line: https://github.com/monero-project/monero/blob/master/src/simplewallet/simplewallet.cpp#L6320

priority = m_wallet->adjust_priority(priority);

So #9219 should fix this

@SChernykh
Copy link
Contributor

SChernykh commented Mar 8, 2024

After looking at the code a bit more, shouldn't this line assign to the default priority, not 0? https://github.com/monero-project/monero/blob/master/src/simplewallet/simplewallet.cpp#L6316

uint32 priority = 0;

should be

uint32 priority = m_wallet->get_default_priority();

@SChernykh
Copy link
Contributor

@selsta you can just add the one-line fix above to #9219

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants