wallet2: make unsigned/signed tx portable

[kenshi84]

As discussed in Issue #2 of onion-monero-blockchain-explorer, currently the serialized files of unsigned/signed transactions are unportable; e.g., the tx pusher hosted by MoneroWorld.com can work accept files created in Linux. This PR solves the problem.

[moneromooo-monero]

I assume the BEGIN_SERIALIZE_OBJECT() bits aren't used on those types anymore ? Then plese remove them, or any changes to the structure will cause this to change, and cause the new ones to be forgot. If the BEGIN_SERIALIZE_OBJECT() isn't here, the coder will not think he's done the serialization changes.

[moneromooo-monero]

And bump the file format version.
Other than that, ok.

[kenshi84]

@moneromooo-monero

I assume the BEGIN_SERIALIZE_OBJECT() bits aren't used on those types anymore ?

Removing it will make it impossible to read existing serialized files. If that's acceptable, I'll remove it.

And bump the file format version.

OK

[moneromooo-monero]

That's fine. The version check would prevent this too. And if you don't bump the version, you end up with two incompatible sets of files with the same version number.

[kenshi84]

Is it OK now?

[moneromooo-monero]

You did not bump the file version number (look for UNSIGNED_TX_PREFIX and SIGNED_TX_PREFIX)

[kenshi84]

Thanks, I was completely overlooking it.

[kenshi84]

Closing for now, as it turns out that Boost's unofficial portable serializer has a flaw, see Issue #1511

[kenshi84]

Reopened due to the cause of the error being understood, see PR #1515

[ghost]

Would it make sense to squash this one and #1515 together as a single working PR?

[kenshi84]

@NanoAkron That makes sense, thanks for the suggestion! Closing this PR as such.