Latest code for dvwae436pd7nt4bc.onion ?

[jonathancross]

I am seeing mismatches between the code here and that being served from dvwae436pd7nt4bc.onion -- should they match?

As a simple sanity check, I compared the HTML titles:

• header.html#L9 :
  <title>Onion Monero Blockchain Explorer</title>
• dvwae436pd7nt4bc.onion :
  <title>Monero Explorer</title>

[notsuhz]

dvwae436pd7nt4bc.onion (explorer.xmr.my) is currently using unmerged branch add_network_info_front_page

and the front-end template is from
https://github.com/suhz/onion-monero-blockchain-explorer/tree/new_template/src/templates

thus explain the difference.

[jonathancross]

Thanks @suhz. Will those change from your fork be merged upstream to this repo or should people submit PRs to your fork?

[notsuhz]

@jonathancross I'll do PR to this repo once add_network_info_front_page is merged, because my templates depends on that branch.

[moneroexamples]

@suhz @jonathancross

I can merge branch add_network_info_front_page now, unless you have some issues or feature request for the network info? Currently, working on making mempool processing and monitoring in its own thread, so I'm not adding anything new to network info. The emission numbers seem to be good now from what I can test.

One note though. The git procedure for building monero changed. Before it had git checkout -b v0.10.3.1 which was incorrect. This was just creating branch called v0.10.3.1, rather than checking out release tag v0.10.3.1. The line was changed to: git checkout -b last_release v0.10.3.1. So you might need to redo monero compilation if the compilation fails.

[jonathancross]

I can merge branch add_network_info_front_page now...

Sounds good to me :-)

[notsuhz]

@moneroexamples I don't have anything to add :-)

[moneroexamples]

@suhz @jonathancross

Merged :-)

[jonathancross]

Cheers :-)
@moneroexamples Did you want to keep the front-end template stored in @suhz's repo or would it make sense to maintain that here as well? Personally I expected to find the template code here, but we could update the README to point out front-end template locations.

[moneroexamples]

@jonathancross

I think link to @Suh'z repo would be better. I like to keep onion explorer very basic so that its easier to change its frontend or backend for anyone in their own versions if the want.

Do you want to make PR to add the link it to readme?

[notsuhz]

@jonathancross At first I was thinking to PRs to @moneroexamples , but then I think it would be easier for me to maintain my front-end version of my explorer in its own repo. And, If anyone interested with that version, they can freely use that :)

[jonathancross]

Do you want to make PR to add the link it to readme?

@moneroexamples Cheers: #67