Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI focus feature fixed #1212

Merged
merged 11 commits into from
Nov 16, 2022
Merged

UI focus feature fixed #1212

merged 11 commits into from
Nov 16, 2022

Conversation

shubhay09
Copy link
Contributor

No description provided.

hovering function added as well as red highlight to let users now its important 

Signed-off-by: shubhay09 <82525849+shubhay09@users.noreply.github.com>
Signed-off-by: shubhay09 <82525849+shubhay09@users.noreply.github.com>
Signed-off-by: shubhay09 <82525849+shubhay09@users.noreply.github.com>
@elliotcourant
Copy link
Member

Why close the original pull request?

@shubhay09
Copy link
Contributor Author

i thought it was not going to work can you review the changes ??

@shubhay09
Copy link
Contributor Author

i dont know why im getting deepsource javascript error can you help out ?

Copy link
Contributor Author

@shubhay09 shubhay09 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

review required

@shubhay09 shubhay09 marked this pull request as draft November 14, 2022 13:21
Signed-off-by: shubhay09 <82525849+shubhay09@users.noreply.github.com>
Copy link
Member

@elliotcourant elliotcourant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some small tweaks then this should be good to go!

shubhay09 and others added 4 commits November 17, 2022 00:58
Co-authored-by: Elliot Courant <me@elliotcourant.dev>
Signed-off-by: shubhay09 <82525849+shubhay09@users.noreply.github.com>
Co-authored-by: Elliot Courant <me@elliotcourant.dev>
Signed-off-by: shubhay09 <82525849+shubhay09@users.noreply.github.com>
Co-authored-by: Elliot Courant <me@elliotcourant.dev>
Signed-off-by: shubhay09 <82525849+shubhay09@users.noreply.github.com>
Co-authored-by: Elliot Courant <me@elliotcourant.dev>
Signed-off-by: shubhay09 <82525849+shubhay09@users.noreply.github.com>
@shubhay09 shubhay09 marked this pull request as ready for review November 16, 2022 19:29
@shubhay09
Copy link
Contributor Author

changes have been made

Copy link
Contributor Author

@shubhay09 shubhay09 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes have been you can review now and let me know anything else to be done or changed

@elliotcourant elliotcourant merged commit 4523237 into monetr:main Nov 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug(ui): Terms of use and privacy policy links on sign up page should change on focus.
2 participants