-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(api): Migrating to ULID instead of 64-bit integer IDs #1740
Conversation
I think instead of generating the initial ULIDs in go they should be done via this: https://github.com/geckoboard/pgulid This way the migration can be done as a single SQL migration rather than multiple. |
This will make writing data in bulk easier in the future, it will also make this data more portable between environments or between databases.
229df5b
to
9bd88e5
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1740 +/- ##
==========================================
+ Coverage 50.46% 52.13% +1.67%
==========================================
Files 366 358 -8
Lines 20363 18525 -1838
Branches 500 502 +2
==========================================
- Hits 10276 9658 -618
+ Misses 9523 8325 -1198
+ Partials 564 542 -22 ☔ View full report in Codecov by Sentry. |
The code side is complete, now its just fixing tests or fixing code depending on how the test fails. Also the fixtures I had generated a long time ago for forecasting need to be regenerated somehow. |
with math rand it is possible to generate duplicate IDs.
This will make writing data in bulk easier in the future, it will also
make this data more portable between environments or between databases.