TO BE DELETED: One category list: nested category #1552
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…com/moneymanagerex/general-reports/tree/master/packages/Category/OneCategoryList). Main Change: * add one_category_list.sql * Alter query_alldata.sql for using recursive category * alter query_categorysubcategory.sql for using recursive category * alter query_mobiledata.sql for using recursive category * adapt CategoriesReportFragment * adapt CategoryRepository * adapt CategoryService * adapt ViewMobileData Tested-by: wolfsolver Test execution: * Category List * Category Edit * Category Add - Root * Category add - Child * Category Delete * Report Category * Report Income/Expence * Search view * Transaction List * Transaction Edit * Transaction Add
|
Dont' know how to fix failed check on Codacy... @guanlisheng any suggestion? |
|
as the change is big, it is better to split it into multi-small pieces and do enough tests (especially on compatibility) |
|
@guanlisheng can you help me to understand how to change SQL query for codacy compatibility? https://app.codacy.com/gh/moneymanagerex/android-money-manager-ex/pullRequest?prid=13555377 |
|
Does make sense to create a beta release for this? |
|
if you are confident, let's roll out directly. don't forget to document related changes |
wolfsolver
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial release for recursive categories
See #1376 (comment)