Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Account types available on Desktop are different to Android app #1551

Closed
luisdev opened this issue Feb 2, 2024 · 8 comments
Closed

Account types available on Desktop are different to Android app #1551

luisdev opened this issue Feb 2, 2024 · 8 comments
Assignees

Comments

@luisdev
Copy link

luisdev commented Feb 2, 2024

Describe the bug
User Bobb reported the following issue in the Android and Desktop forums.
See the posts here:
https://forum.moneymanagerex.org/viewtopic.php?t=10988
https://forum.moneymanagerex.org/viewtopic.php?t=10987

To Reproduce
I've seen the update Android update 2024.01.10 (1011) on Facebook and downloaded it.

First response, very happy with the improving software, a credit to ALL developers - THANK YOU!

I have noticed a couple of differences between Android and Windows apps, and terminology affects how entries in accounts are displayed, if at all.

Windows version 1.7.0 64 bit
Account types available

Cash
Checking
Credit card
Loan
Term
Asset
Shares

Android 2024.01.10 (1011)
Account types available

Cash
Checking
Investment
Term
Credit card
Loan
Shares

In the Windows version I have listed my house under assets,. and I can see the entry in Account view. However, on Dashboard view Assets are '0'

When I open the updated file created in Windows, in the Android version the Account House appears as an asset in Home (Dashboard), but when I open the account I don't get the details of the asset, it opens one of my Bank Accounts. I assume its an issue with the links between Asset and Investment etc., and the different account types across the two platforms.

@luisdev luisdev added the bug label Feb 2, 2024
@guanlisheng
Copy link
Contributor

thanks, @luisdev, and I believe you can also fix the issue. btw, can you rename the issue name to better desc the issue (and to avoid the misleading as well).

@luisdev
Copy link
Author

luisdev commented Feb 2, 2024

Thanks @guanlisheng, but I just copied and pasted the message that user Bobb posted in the forum. I didn't experience the problem myself.

Are you saying that this is a MMX setup or data issue, not a bug?

@guanlisheng
Copy link
Contributor

great to reproduce and understand the issue. this might be a good opportunity for you

@luisdev luisdev changed the title UPDATE Synchronisation across windows and Android. Account types available on Desktop are different to Android app Feb 4, 2024
@guanlisheng
Copy link
Contributor

guanlisheng commented Feb 7, 2024

hi @luisdev, i think it is configured here and can you have a look?
https://github.com/moneymanagerex/android-money-manager-ex/blob/master/app/src/main/res/values/arrays.xml#L76-L84

also, we can polish MMEX4Desktop's

@luisdev
Copy link
Author

luisdev commented Feb 7, 2024

I'm making a huge guess here, but MMX Desktop
https://github.com/moneymanagerex/moneymanagerex/blob/27126269d882ee8633c78d92952351e721807668/src/model/Model_Account.h#L36
lists the accounts as:

enum TYPE { CASH = 0, CHECKING, CREDIT_CARD, LOAN, TERM, INVESTMENT, ASSET, SHARES, MAX};

But, as you pointed out, Android app lists them on:
https://github.com/moneymanagerex/android-money-manager-ex/blob/master/app/src/main/res/values/arrays.xml#L76-L84
as:

<string-array name="accounttype_items">
    <item>@string/cash</item>
    <item>@string/checking</item>
    <item>@string/investment</item>
    <item>@string/term</item>
    <item>@string/credit_card</item>
    <item>@string/loan</item>
    <item>@string/shares</item>
</string-array>

So, they're not in the same order. Do we fix this by changing the ORDER that the account types are listed on the Android app to:

<string-array name="accounttype_items">
    <item>@string/cash</item>
    <item>@string/checking</item>
    <item>@string/credit_card</item>
    <item>@string/loan</item>
    <item>@string/term</item>
    <item>@string/investment</item>
    <item>@string/shares</item>
</string-array>

What about the ASSET type that is displayed on Desktop but not on Android? Is it just a case of adding:

    <item>@string/asset</item>

to Andoid? Is there existing code to support this, or is the Asset account type not supported on Android yet?

Of course, I could be talking total nonsense! ;-)

@guanlisheng
Copy link
Contributor

Your guess is almost right and you can verify it by making changes.
we expect you can help to resolve this issue if you are willing

Copy link

github-actions bot commented May 8, 2024

This issue is stale because it has been open 90 days with no activity. Remove stale label or comment or this will be closed in 5 days.

Copy link

This issue was closed because it has been stalled for 5 days with no activity.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

No branches or pull requests

2 participants