Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update LUA and wxSQLite3 to latest versions #3275

Open
grumpy235 opened this issue Apr 16, 2021 · 5 comments
Open

Update LUA and wxSQLite3 to latest versions #3275

grumpy235 opened this issue Apr 16, 2021 · 5 comments
Milestone

Comments

@grumpy235
Copy link

I noticed @whalley has raised the idea of wxWidgets upgrade to 3.1.5 and there is also a suggestion to bring Curl up to date.
Any thoughts on upgrading LUA to 5.4.3 and wxSQLite3 to 4.6.9 ?

I have been running both for a while now on my local copy of mmex on WIN10 using an encrypted database with no problems at all.

Extremely limited Cmake knowlege meant I made the following changes...

For LUA, I changed 3rd/CMakeLists as follows...

  1. LUA_COMPAT_5_2 to LUA_COMPAT_5_3
  2. Adjust modules to compile
    add lua/ljumptab.h and lua/lopnames.h
    remove lua/lbitlib.c
  3. I also commented out some of the Linux stuff as from memory Cmake threw a wobbly and my knowledge of Linux and Cmake meant I could not fix it.

For wxSQLite3, things are bit more complex as encryption has been re-packaged and SQLite is now included in wxSQLite3.

  1. MMEX source change #include "sqlite3.h" to #include "sqlite3mc_amalgamation.h" in modules src\dbwrapper.cpp & src\model\Model_Report.cpp - this assumes of course that a version of wxSQLite3 with the new packaging is in use
  2. Extensive changes to 3rd/CMakeLists under "if(NOT wxSQLite3_FOUND OR NOT (WXSQLITE3_HAVE_CODEC OR MMEX_ENCRYPTION_OPTIONAL))"
  3. I guess the code from "find_package(PkgConfig)" relating to wxSQLite3 might also need some work ??

Just in case it might be useful I have attached my modified 3rd/CMakeLists
CMakeLists.txt

@vomikan
Copy link
Member

vomikan commented Apr 16, 2021

How to add dll file usinf CMAKE?
#2714
#3273
#3241

@vomikan
Copy link
Member

vomikan commented Apr 16, 2021

How to update Lua

cd 3rd/Lua
git fetch
git fetch --tags
git checkout v5.4.3
cd ../..
git add 3rd/lua
git commit -m 'Update the Lua to the "v5.4.3" version' 3rd/Lua

@vomikan
Copy link
Member

vomikan commented Apr 16, 2021

This raises the problem of a third-party library that has not been updated for 8 years.
image

Is this project replacement?
https://github.com/TheLartians/LuaGlue

@grumpy235
Copy link
Author

@vomikan Now you remind me I had discovered that when I first upgraded and LUA_COMPAT_5_3 bypassed it for Windows without any further changes. Looking at https://github.com/TheLartians/LuaGlue then Lars has taken his own copy of Lua (commit b1e7a46) which from a comment on the repository will only be updated on an irregular basis - not that there is much going on in Lua any way

@vomikan vomikan added this to the v1.6.0 milestone May 7, 2021
@github-actions
Copy link

github-actions bot commented Nov 9, 2022

This issue is stale because it has been open 365 days with no activity. Please update if you want to keep the issue open

@github-actions github-actions bot added the stale label Nov 9, 2022
@whalley whalley removed the stale label Nov 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants