Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename Full Transactions Report to Account View: All Transactions #6143

Closed
rmelillo76 opened this issue Jul 28, 2023 · 8 comments
Closed

Rename Full Transactions Report to Account View: All Transactions #6143

rmelillo76 opened this issue Jul 28, 2023 · 8 comments
Assignees
Labels
enhancement fixed i18n internationalization and localization
Milestone

Comments

@rmelillo76
Copy link

I recommend we change the panel title to "Account View: All Transactions" for consistency with other account views.

image

@tactilis
Copy link

I agree.

The current inconsistent naming All Transactions => Full Transactions Report has always bugged me as well.

@vomikan
Copy link
Member

vomikan commented Jul 28, 2023

There are two more strings:
_("All Transactions: Withdrawals, Deposits, and Transfers"));
_("All Transactions excluding Transfers"));

https://github.com/moneymanagerex/moneymanagerex/blob/master/src/reports/transactions.cpp#L413

https://github.com/moneymanagerex/moneymanagerex/blob/master/src/reports/transactions.cpp#L395

@vomikan vomikan added the i18n internationalization and localization label Jul 28, 2023
@vomikan vomikan added this to the v1.7.0 milestone Jul 28, 2023
@vomikan vomikan self-assigned this Jul 28, 2023
@tactilis
Copy link

There are two more strings:
_("All Transactions: Withdrawals, Deposits, and Transfers"));
_("All Transactions excluding Transfers"));

Are they in Reports somewhere? How do you get to see them?


Rich and I are talking about the All Transactions entry in the Navigation tree, which produces a (filterable) all transactions list.

@ovari
Copy link
Contributor

ovari commented Aug 2, 2023

All Transactions: Withdrawals, Deposits, and Transfers
https://crowdin.com/translate/moneymanagerex/470/en-hu#797570

All Transactions excluding Transfers
https://crowdin.com/translate/moneymanagerex/470/en-hu#797572

@rmelillo76
Copy link
Author

All Transactions: Withdrawals, Deposits, and Transfers

https://crowdin.com/translate/moneymanagerex/470/en-hu#797570

All Transactions excluding Transfers

https://crowdin.com/translate/moneymanagerex/470/en-hu#797572

We should also remove the word "Report"

The thought was to have the title be "All Transactions"

@ovari
Copy link
Contributor

ovari commented Aug 2, 2023

@rmelillo76 is https://github.com/moneymanagerex/moneymanagerex/pull/6153/files#diff-63b4bc6b9e6dffe709948324f1c8375f7979cc30862f66769fd67fb4e0410b1f what you had in mind? Thank you

@rmelillo76
Copy link
Author

@vomikan vomikan assigned ovari and unassigned vomikan Aug 3, 2023
@ovari
Copy link
Contributor

ovari commented Aug 3, 2023

@vomikan can you please close this issue? Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement fixed i18n internationalization and localization
Projects
None yet
Development

No branches or pull requests

5 participants