-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: allow customising export params (e.g. installing with extras
)
#35
Comments
Hi @alex-grover Yes sure, you can provide a PR for this. :) |
Hi @alex-grover , maybe we could introduce a generic option like I have made a TAP-based test suite for this buildpack to make meaningful local development possible, if you make a nice PR and cover it with tests, we will be happy to accept it. |
That sounds like a good solution. Since opening this issue, my company has moved to a Docker-based local dev setup so I don’t have the need/time to make the PR myself unfortunately |
extras
extras
)
extras
)extras
)
@alex-grover thanks for the heads up. Unfortunately, we don't have the capacity to work on this, and we don't need it for our application, so we won't implement it immediately. I will leave this issue as open in the case that somebody comes across and wants to implement this, or maybe we get extra time to invest in this buildpack. |
Hello - thanks for this buildpack, we are successfully using it in production!
My issue: I'd like to have a dependency that's only installed in production, and not in development. In particular, it's recommended to use
psycopg2-binary
in development and buildpsycopg2
from source for production.Based on this issue it seems that the Poetry recommendation for this use case is to install the prod dependency as an
extra
and then dopoetry install/export -E production
when you want to install the prod version.My ideal solution would be to set an environment variable in Heroku that sets the
-E
in for the export step in this buildpack. If this is something you'd be willing to accept I can take a stab at implementing and open a PR, let me know!The text was updated successfully, but these errors were encountered: