Careful with string vs int

[frederikbosch]

Now that there are no more integer limitations (#115), we have to be careful with int and string usage vs strict comparison. This is something that I did not cover in my PR but now realize that should be taken care of. Especially with these lines.

• isZero
• isPositive
• isNegative
• equals

These lines are now buggy, because the following will return false.

(new Money(1, new Currency('EUR')))->equals(new Money('1', new Currency('EUR')))

I guess we should convert the amount to a string in the constructor with (string). PR is on the way.

[frederikbosch]

PR created. I was partially right: isZero, isPositive and isNegative were fine. Nonetheless added a test for them. equals was not fine since the line was changed in #131. However, I do agree, strict comparison is better than loose comparison.

[sagikazarmark]

Is this a good idea with the PhpCalculator

[frederikbosch]

Good question, let's test it.

[frederikbosch]

Added another commit to the PR. The PhpCalculator now returns string where required.

[sagikazarmark]

So calculators return strings and integers based on what?

[frederikbosch]

Calculators return an integer in the compare method, so 1, 0 and -1. Other methods return a string now.

[frederikbosch]

Fixed in #136.