Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix StyleCI #426

Closed
frederikbosch opened this issue Nov 14, 2017 · 6 comments
Closed

Fix StyleCI #426

frederikbosch opened this issue Nov 14, 2017 · 6 comments

Comments

@frederikbosch
Copy link
Member

It is a bit annoying at the moment to say the least.
@frederikbosch frederikbosch mentioned this issue Nov 14, 2017
Closed
17 tasks
@frederikbosch
Copy link
Member Author

Maybe just disable/remove it.

@sagikazarmark
Copy link
Collaborator

Yeah, it's because of the Yoda condition rule added by StyleCI. I can turn that rule off and styleci should be ok if you wish.

@frederikbosch
Copy link
Member Author

Is there not some setting that only reviews code changes? Instead of the whole package? Personally, I totally not like Yoda, so I would be against it.

@Jean85
Copy link

Jean85 commented Dec 1, 2017

Wouldn't be good to integrate a tool like PHP-CS-Fixer to have a fast way to fix CS on the dev side?

@frederikbosch
Copy link
Member Author

@sagikazarmark Can you turn Yoda off? I don't think I can do that. We already demand strict equality. That should be enough.

@sagikazarmark
Copy link
Collaborator

Can you turn Yoda off?

On it

@sagikazarmark sagikazarmark mentioned this issue Dec 11, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@sagikazarmark @frederikbosch @Jean85