-
Notifications
You must be signed in to change notification settings - Fork 169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unreadable subtitles #38
Comments
Works for me. Configure or disable your styling in caption preferences: https://github.com/moneytoo/Player#how-do-i-change-subtitle-font-size-or-color |
Accessibility isn't enabled in my smartphone and the caption preferences also aren't enabled. (Also, looking at your screenshot, looks like it's half working because this first subtitle of the video is supposed to be italic styled, but I guess this isn't related to this issue(?)) |
Yes, ExoPlayer capabilities for supporting subtitles styling is quite limited. I will check to see if it handles even italic. Could you try enabling Caption preferences and see if you can override the style? So in your case the subtitles are white with white outline? I'm using I will try testing it on some older Xiaomi device in a few days. |
Can you try playing any video with captions using NewPipe. It also uses ExoPlayer so we can verify if it's ExoPlayer or device issue and not implementation here. |
Yes, I just did what you asked and saw that NewPipe has the same issue. |
I have few more ideas but I will try test it myself during the weekend and get back to you if I won't be able to proceed without your help. |
Ok! I will be waiting, good luck :D |
It also works fine for me on older Xiaomi Redmi Note 4. There are however reports of similar issue on newer Xiaomi devices:
Try this bare test app: https://brouken.com/tmp/test.apk with enabled captions and check if it changes the edge. This sample uses platform VideoView so we know whatever this is ExoPlayer issue or not. |
The test app doesn't show any captions, but the caption edge do work properly on youtube and, as expected, in the default video player. Edit: Nevermind, the caption wasn't showing because of the language that I had selected, now it shows the caption but, yeah, it also doesn't have the edge color... Edit 2: I found something really interesting, if I select the "Blue" edge color, the edge color that the video player (and the test app) shows is a pink one! 🤔 Edit 3: Ok, I found the issue, the dark mode of my phone was inverting the edge color, so black was turning white and blue was turning pink... I guess if you could somehow ignore the dark mode in your app this issue could be solved |
Does dark mode trigger the issue in YouTube as well? |
No, I guess because youtube has its own dark mode toggle, changing the dark mode on my phone doesn't affect youtube in any way. |
How about this version: http://brouken.com/tmp/just-player-no_force_dark.apk ? |
Yeah, this one shows the subtitle correctly with and without dark mode enabled! |
Hello! I just found this interesting app but I already encountered a issue with it... The video that I tried to play has unreadable subtitles in this app but for example in VLC the subtitles appears normally.
(If you look closely the subtitles is there but it's just white)
Here is an example of how it looks on the VLC player:
This video can be found here: https://nyaa.si/view/1324339
The text was updated successfully, but these errors were encountered: