Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Streaming #11

Closed
hieulbp opened this issue Dec 31, 2020 · 6 comments
Closed

Streaming #11

hieulbp opened this issue Dec 31, 2020 · 6 comments
Labels
enhancement New feature or request wip Work in progress

Comments

@hieulbp
Copy link

hieulbp commented Dec 31, 2020

Can u support play streaming like .m3u, m3u8, dash, hls,... tks very much

@moneytoo
Copy link
Owner

I was thinking about that but:

  • I personally don't use it (and don't know much content to test it with).
  • There are already other ExoPlayer based apps that are made (primarily or only) for streaming content.
  • Wouldn't it also require additional UI? Bookmarked/recent streams?
  • Supporting streaming would require the Internet permission. I'm actually perceiving not having permission to access Internet as an advantage - especially for the FOSS folks. I have already noticed positive feedback regarding no internet permission.

@moneytoo
Copy link
Owner

On the other hand I understand there might be a lot of demand for this feature. I would also like to do that if that's just a few lines of code, especially since it doesn't need new action in control bar. To still offer offline version, I could just create another build variant, just like Keepass2Android does.

@moneytoo moneytoo added enhancement New feature or request wip Work in progress labels Jan 10, 2021
@moneytoo
Copy link
Owner

I'm trying out streaming with this build: Just.Player.v0.13-streaming.apk.zip

Does this handle streaming as you would expect? I tested it with these file extensions:

<data android:pathPattern=".*\\.3gp" />
<data android:pathPattern=".*\\.m3u8" />
<data android:pathPattern=".*\\.m4v" />
<data android:pathPattern=".*\\.mkv" />
<data android:pathPattern=".*\\.mov" />
<data android:pathPattern=".*\\.mp4" />
<data android:pathPattern=".*\\.mpd" />
<data android:pathPattern=".*\\.webm" />

Is anything missing?

@hieulbp
Copy link
Author

hieulbp commented Jan 12, 2021

streaming is play url, but I could not more url and referer header

@CorvetteCole
Copy link

would love to get streaming support as well, will test shortly. This is the only app besides the default google video player that can play 4k60FPS on my chromecast with google tv

@moneytoo
Copy link
Owner

Basic support should be available in the -online version in releases here on Github. F-Droid and Google Play will keep the -offline build.

I only added support for extensions I was able to find and test so let me know in a new issue if anything is missing (with some sample to test).

@hieulbp I'm afraid that setting things like referer headers is too complex for this little app.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request wip Work in progress
Projects
None yet
Development

No branches or pull requests

3 participants