Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Magic signer #97

Merged
merged 8 commits into from Oct 27, 2022
Merged

Magic signer #97

merged 8 commits into from Oct 27, 2022

Conversation

Ethella
Copy link
Contributor

@Ethella Ethella commented May 27, 2022

Hi Tezart team, this is Jerry from Magic Link. 馃憢

Per requests from our customers, we are trying to support Tezos on Flutter with our key management infrastructure. And your library has been recommended by our customers.

However, within your implementation, there's been a challenge for us to integrate a remote signer from a third party like us. So I added a RemoteSigner param in Keystore to sign remotely, and I've tested it locally to make sure it works. The example will be documented on our docs.magic.link website

Hope you can adopt this change, and I can guide our clients to use your awesome libraries with our Magic Auth. Please lmk if there's anything that I need to update. I'll make up the tests after you guys are agreeing on the implementation.

@Ethella Ethella marked this pull request as draft May 27, 2022 22:32
@Pierre-Michard
Copy link
Contributor

Hi Ethella,
thanks for your contribution.
I don't see the package blockchain_signer you've added to the project anywhere. Is that a public project?
By the way, would it be possible to avoid adding such a dependency, by using a generic interface, which could fit to other remote signers?

@Ethella
Copy link
Contributor Author

Ethella commented May 30, 2022

Hi @Pierre-Michard!

The package blockchain_signer is currently in review right now. We'll publish it once it's consolidated. https://github.com/magiclabs/blockchain-mobile-signer/pull/1/files.

As you can see from the links above, it's a lightweight generic interface and it may support Ledger Signer and InMemeory Signers. Based on our plan, we want to gradually iterate on it to support the rest of the collaborative chains for Flutter.

The reason why we make a it a standalone library is because, from our experience, our customers have requested multiple times about decoupling blockchain libraries and our sdks to make it lightweight and flexible.

Please let me know your thoughts

@Ethella Ethella marked this pull request as ready for review July 24, 2022 23:41
@Pierre-Michard Pierre-Michard merged commit 8dea892 into moneytrackio:main Oct 27, 2022
@Ethella
Copy link
Contributor Author

Ethella commented Nov 8, 2022

Thx for merging this! Can we direct our flutter Tezos customers to you?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants