Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check if NO installer running? #16

Open
MTRNord opened this issue Sep 16, 2016 · 7 comments
Open

Check if NO installer running? #16

MTRNord opened this issue Sep 16, 2016 · 7 comments

Comments

@MTRNord
Copy link

MTRNord commented Sep 16, 2016

How can I check if NO installer is running? Because when it runs the Autoupdater crash because there is an lock file.

@ccnokes
Copy link

ccnokes commented Jun 6, 2017

This seems like a good enhancement.....not sure how it would be implemented though because basically the solution to that is to not autoUpdater.checkForUpdates when --squirrel-firstrun is in the app args (see electron/electron#7155 (comment))

@kuworking
Copy link

Can it be done with electron-builder?

var autoUpdater = require('electron-auto-updater').autoUpdater;
let squirrelEvent = process.argv[1];
if (squirrelEvent !== '--squirrel-firstrun')
   autoUpdater.checkForUpdates();

@develar
Copy link

develar commented Jul 25, 2017

Electron-builder doesn't use Squirrel.windows by default.

@kuworking
Copy link

Then how can we detect the '--squirrel-firstrun' when using electron-builder?

@develar
Copy link

develar commented Jul 25, 2017

Please file issue to electron-builder and explain what do you want to achieve.

@kuworking
Copy link

It is the same issue asked here: How to avoid Autoupdater crashing when squirrel is doing its first run?

In order to avoid that we'd need to detect the --squirrel-firstrun flag, so in order to answer this question, we need to answer this other question: how can we detect the --squirrel-firstrun flag with Electron-builder?

If you suggest so I will open a separated issue, but in my eyes it would be redundant to this one

@develar
Copy link

develar commented Jul 25, 2017

If you can — just do not use Squirrel, default target for Windows is nsis.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants