chore(build): make addon buildable as static library #119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Require libcom_err when building a static library because the code accesses `error_message()` which comes from it - Use `-l` prefix for included libs for Windows The goal here is to bundle this library as part of the `mongosh` binary itself.
|
@addaleax LGTM, is there a Jira ticket for this? |
|
@mbroadst No, not yet. Edit: Opened https://jira.mongodb.org/browse/NODE-2956 for this. |
|
@mbroadst Small ping? :) |
mbroadst
approved these changes
Mar 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
because the code accesses
error_message()whichcomes from it
-lprefix for included libs for WindowsThe goal here is to bundle this library as part of the
mongoshbinary once we start enabling kerberos functionality in it.
I figured that opening a pull request early was a good idea so that
we might not need to wait for another kerberos release once we
start the actual work itself :)