Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RUST-1680: put trust-dns-resolver under feature flag #896

Open
Logarithmus opened this issue Jun 16, 2023 · 3 comments
Open

RUST-1680: put trust-dns-resolver under feature flag #896

Logarithmus opened this issue Jun 16, 2023 · 3 comments
Assignees
Labels
tracked-in-jira Ticket filed in Mongo's Jira system

Comments

@Logarithmus
Copy link

As far as I understand, this is only used for mongodb+srv:// connection strings. I don't use it, and trust-dns-resolver takes significant time to compile, and is whopping 34k lines of code! https://lib.rs/crates/trust-dns-resolver.
So making it an optional dependency would be very appreciated. I can make a PR if you say my reasoning is correct.

@abr-egn
Copy link
Contributor

abr-egn commented Jun 20, 2023

Hi!

You're right that moving trust-dns-resolver to optional would make sense; unfortunately, that would be a breaking change, so we need to defer that to when we make a 3.0 release (won't be in the near future). I've filed https://jira.mongodb.org/browse/RUST-1680 to track it so we include it when we do get to that point!

@abr-egn abr-egn added tracked-in-jira Ticket filed in Mongo's Jira system and removed triage labels Jun 20, 2023
@Logarithmus
Copy link
Author

@abr-egn in fact we can make trust-dns-resolver feature enabled by default, this way it won't be a breaking change and everyone will be happy!

@abr-egn
Copy link
Contributor

abr-egn commented Jun 20, 2023

Even with that, it'll still be breaking for users who have disabled default features.

@Logarithmus Logarithmus changed the title Put trust-dns-resolver under feature flag RUST-1680: put trust-dns-resolver under feature flag Jun 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tracked-in-jira Ticket filed in Mongo's Jira system
Projects
None yet
Development

No branches or pull requests

2 participants