fix(mongos): bubble up error events after the first one #1685
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Re: Automattic/mongoose#6249. Not really sure why this is a `once()` instead of an `on()`, but the current behavior makes it so that subsequent `close` events never make it up to the client, so `db.on('close')` will never get fired if a mongos dies for the 2nd time.
|
Gonna close this one for now since its stale, I'll open up a new one later |
mbroadst
pushed a commit
that referenced
this pull request
May 31, 2018
mbroadst
pushed a commit
that referenced
this pull request
May 31, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re: Automattic/mongoose#6249. Not really sure why this is a
once()instead of anon(), but the current behavior makes it so that subsequentcloseevents never make it up to the client, sodb.on('close')will never get fired if a mongos dies for the 2nd time. I wanted to double check that this wasn't completely off base before I put in the effort to write a test.