Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix test filters and revert mocha version #2558

Merged
merged 3 commits into from
Oct 2, 2020

Conversation

nbbeeken
Copy link
Contributor

Our tests were all being filtered out on node 4 by the client_encryption_filter.
This also rolls back mocha to run on older nodejs versions.

Copy link
Contributor

@reggi reggi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 😭

@nbbeeken nbbeeken requested a review from mbroadst October 1, 2020 15:09
Copy link
Member

@mbroadst mbroadst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@nbbeeken nbbeeken merged commit 0e5c45a into 3.6 Oct 2, 2020
@nbbeeken nbbeeken deleted the chore/tooling-sync-hotfix branch October 2, 2020 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants