fix: Change socket timeout default to 0 #2564
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Socket timeout by default should be infinity. NODE-2835
reggi
approved these changes
Oct 6, 2020
There was a problem hiding this comment.
LGTM
Maybe worth adding a @default tag to the Client options interface.
https://github.com/mongodb/node-mongodb-native/blob/master/src/mongo_client.ts#L78
I would but as of now TSDoc doesn't have default 😅 support for this tag microsoft/tsdoc#27, we could always enable it as a custom tag but we need a pipeline that does something with the information. I can use the |
|
@nbbeeken I would have expected some tests here, can you please add one/some? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Socket timeout by default should be infinity.
Removed 6min defaults.
NODE-2835