fix: boron node version test failures #2747
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emadum
approved these changes
Mar 5, 2021
| @@ -1264,7 +1264,7 @@ describe('Indexes', function() { | |||
| metadata: { | |||
| requires: { | |||
| topology: ['single', 'replicaset', 'sharded', 'ssl', 'heap', 'wiredtiger'], | |||
| mongodb: '>=3.0.0' | |||
| mongodb: '>=3.0.0 <=4.8.0' | |||
There was a problem hiding this comment.
Do you have more context on what is going on with this test? I've seen it fail on some of my CI runs against latest as well.
There was a problem hiding this comment.
Looks like version 4.9.0-alpha5-148-g3a70e27 now returns code 86 instead of 85 for this use case, figured we might as well keep the test running on versions prior to that. I went with capping it at the minor version just to be sure we don't run into this on newer versions
This was referenced Mar 16, 2021
This was referenced Mar 17, 2021
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some of the deprecation warnings are formatted a little different in node boron (v6), updated the tests to account for that.