[PORT] fix: move session support check to operation layer #2750
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nbbeeken
force-pushed
the
NODE-3100/PORT/4.0/fix-sessions-issue
branch
from
0afd464
to
fbb4bb4
Compare
Session support check is now performed after server selection this ensures the monitor was able to update the topology description NODE-3100
nbbeeken
force-pushed
the
NODE-3100/PORT/4.0/fix-sessions-issue
branch
from
fbb4bb4
to
9d10de4
Compare
nbbeeken
commented
Mar 11, 2021
Comment on lines
+51
to
+52
| // TODO: Each operation defines its own options, there should be better typing here | ||
| options: Document; |
There was a problem hiding this comment.
This was necessary type information for executeWithServerSelection
emadum
approved these changes
Mar 17, 2021
ljhaywar
pushed a commit
that referenced
this pull request
Nov 9, 2021
Session support check is now performed after server selection this ensures the monitor was able to update the topology description NODE-3100
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Session support check is now performed after server selection
this ensures the monitor was able to update the topology description
NODE-3100