Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: ensure cursor readPreference is applied to find operations #2751

Merged
merged 1 commit into from
Mar 25, 2021
Merged

fix: ensure cursor readPreference is applied to find operations #2751

merged 1 commit into from
Mar 25, 2021

Conversation

emadum
Copy link
Contributor

@emadum emadum commented Mar 10, 2021

@emadum emadum marked this pull request as ready for review March 10, 2021 21:29
@emadum emadum requested review from nbbeeken and durran March 10, 2021 21:29
nbbeeken
nbbeeken approved these changes Mar 11, 2021
View reviewed changes
Copy link
Contributor

@nbbeeken nbbeeken left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀
Should we add tests to catch this?

@durran
Copy link
Member

durran commented Mar 15, 2021

LGTM 🚀
Should we add tests to catch this?

Agreed, could be just a unit test on execute that mocks out the server.

@emadum emadum merged commit 91ba19e into 3.6 Mar 25, 2021
@emadum emadum deleted the NODE-3129/fix-find-setReadPreference branch March 25, 2021 22:30
@emadum
Copy link
Contributor Author

emadum commented Mar 25, 2021

Added a ticket to add the test: NODE-3172

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nbbeeken nbbeeken nbbeeken approved these changes

@durran durran Awaiting requested review from durran

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@emadum @durran @nbbeeken