Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NODE-3122: Always close gridfs upload stream on finish #2758

Merged
merged 1 commit into from
Mar 16, 2021

Conversation

durran
Copy link
Member

@durran durran commented Mar 15, 2021

Tests will hang on Node 14 so just updated Evergreen config with the fix.

@durran durran requested a review from emadum March 15, 2021 22:37
@durran durran assigned nbbeeken and unassigned nbbeeken Mar 15, 2021
@durran durran requested a review from nbbeeken March 15, 2021 22:37
Copy link
Contributor

@nbbeeken nbbeeken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀 I suspect we need this fix in 4.0 as well right?

@durran
Copy link
Member Author

durran commented Mar 16, 2021

Yeah I'm doing a 4.0 PR now.

@durran durran merged commit c976a01 into 3.6 Mar 16, 2021
@durran durran deleted the NODE-3122/gridfs-upload-stream-close branch March 16, 2021 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants