fix(sdam): topology no longer causes close event #2792
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The topology was emitting both a "topologyClosed" and "close" event which are bubbled up to the MongoClient. This was causing two "close" events to be emitted from the MongoClient when the client is closed. NODE-3219
durran
requested review from
emadum,
a team,
nbbeeken and
dariakp
and removed request for
a team
emadum
approved these changes
Apr 27, 2021
ljhaywar
pushed a commit
that referenced
this pull request
Nov 9, 2021
The topology was emitting both a "topologyClosed" and "close" event which are bubbled up to the MongoClient. This was causing two "close" events to be emitted from the MongoClient when the client is closed. NODE-3219
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The topology was emitting both a "topologyClosed" and "close"
event which are bubbled up to the MongoClient. This was causing
two "close" events to be emitted from the MongoClient when the
client is closed.
NODE-3219
Note that there were no tests explicitly looking for that event, but there
are tests looking for the
topologyClosedevent, so I assume this justslipped through.