fix(NODE-2035): exceptions thrown from awaited cursor forEach do not propagate #2835
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nbbeeken
changed the title
nbbeeken
requested changes
Jun 11, 2021
nbbeeken
requested changes
Jun 14, 2021
nbbeeken
approved these changes
Jun 15, 2021
nbbeeken
requested review from
a team,
durran,
dariakp and
emadum
and removed request for
a team
emadum
changed the title
dariakp
requested changes
Jun 15, 2021
emadum
suggested changes
Jun 16, 2021
There was a problem hiding this comment.
Nice work!
In addition to the changes in the afterEach hook, I think the test's readability would be improved by being rewritten using async/await instead of Promise syntax, now that it's available to use in driver v4. Totally up to you whether to do that though, the test LGTM otherwise.
emadum
approved these changes
Jun 16, 2021
dariakp
requested changes
Jun 16, 2021
dariakp
requested changes
Jun 16, 2021
W-A-James
force-pushed
the
NODE-2035/4.0/Exceptions-thrown-from-awaited-cursor-forEach-do-not-propagate
branch
from
70959d9
to
f19b463
Compare
|
Rebased onto 4.0 |
dariakp
requested changes
Jun 17, 2021
test/functional/cursor.test.js
Outdated
| expect.fail('Error in forEach call not caught'); | ||
| }) | ||
| .catch(err => { | ||
| console.log(err.message); |
There was a problem hiding this comment.
extra console log, otherwise LGTM :)
dariakp
approved these changes
Jun 17, 2021
nbbeeken
deleted the
NODE-2035/4.0/Exceptions-thrown-from-awaited-cursor-forEach-do-not-propagate
branch
ljhaywar
pushed a commit
that referenced
this pull request
Nov 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Catch and propagate exceptions in awaited cursor.forEach
What changed?