fix(NODE-3290): versioned api validation and tests #2869
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emadum
force-pushed
the
NODE-3290/3.7/backport-versioned-api-validation
branch
from
5eb64ce
to
7b459d9
Compare
emadum
force-pushed
the
NODE-3290/3.7/backport-versioned-api-validation
branch
from
7b459d9
to
b2e3b3a
Compare
…-versioned-api-validation
emadum
added
the
Primary Review
nbbeeken
requested changes
Jul 1, 2021
|
@emadum This looks ready to go in the sense that it has the validation and tests but the diff looks like its bringing more in than intended, I think 3.7 needs a fastforward before merging? |
…-versioned-api-validation
nbbeeken
added
Team Review
nbbeeken
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of the versioned API updates made in #2809, also pulls in updates to
test/tools/cluster_setup.shfrom 4.0.NODE-3290