New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(NODE-3798): update dependencies; pull in mock server #3067
Conversation
ec7b7fa
to
7cede94
Compare
Partially indeed, I can see about covering all of those points, or updating the ticket to list what's left to do? Any preference? 🙂 |
@nbbeeken It's your hackathon, so up to you, I would tag the ticket in the PR and then add a comment to the Jira saying that the moving part is done, then the ticket is just going to be for clean up (readme/deprecation stuff) |
Updated the ticket, I'm happy to be the one to do the rest of the work later, but not during this week. If we want to close NODE-3798 along with this PR we can move the rest of the AC to a follow up. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, I'd rather merge this now because I'm pretty sure it could potentially conflict with your circular deps work
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good to me - nice work!
Question: It was out of the scope of this work to rewrite the mock server to use BinMsg instead of the legacy op codes. I can't find anything on Jira - do we have a ticket somewhere to update the mock server?
@baileympearson |
Description
What is changing?
Pulled in mock server, removed 'co' dependency, upgraded others.
What is the motivation for this change?
Pulling in the mock server allows us to better debug and make changes as we phase out its use.
Double check the following
npm run check:lint
script<type>(NODE-xxxx)<!>: <description>