Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(NODE-3798): update dependencies; pull in mock server #3067

Merged
merged 4 commits into from Dec 8, 2021
Merged

Conversation

nbbeeken
Copy link
Contributor

@nbbeeken nbbeeken commented Dec 6, 2021

Description

What is changing?

Pulled in mock server, removed 'co' dependency, upgraded others.

What is the motivation for this change?

Pulling in the mock server allows us to better debug and make changes as we phase out its use.

Double check the following

  • Ran npm run check:lint script
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: <type>(NODE-xxxx)<!>: <description>
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket

@nbbeeken nbbeeken added the wip label Dec 6, 2021
@nbbeeken nbbeeken force-pushed the chore/deps branch 2 times, most recently from ec7b7fa to 7cede94 Compare December 6, 2021 22:00
@dariakp
Copy link
Contributor

dariakp commented Dec 7, 2021

@nbbeeken does this partially cover NODE-3798?

@nbbeeken
Copy link
Contributor Author

nbbeeken commented Dec 7, 2021

Partially indeed, I can see about covering all of those points, or updating the ticket to list what's left to do? Any preference? 🙂

@dariakp
Copy link
Contributor

dariakp commented Dec 7, 2021

@nbbeeken It's your hackathon, so up to you, I would tag the ticket in the PR and then add a comment to the Jira saying that the moving part is done, then the ticket is just going to be for clean up (readme/deprecation stuff)

@nbbeeken nbbeeken changed the title chore: update dependencies; pull in mock server chore(NODE-3798): update dependencies; pull in mock server Dec 7, 2021
@nbbeeken
Copy link
Contributor Author

nbbeeken commented Dec 7, 2021

Updated the ticket, I'm happy to be the one to do the rest of the work later, but not during this week. If we want to close NODE-3798 along with this PR we can move the rest of the AC to a follow up.

dariakp
dariakp previously approved these changes Dec 7, 2021
Copy link
Contributor

@dariakp dariakp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I'd rather merge this now because I'm pretty sure it could potentially conflict with your circular deps work

Copy link
Contributor

@baileympearson baileympearson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good to me - nice work!

Question: It was out of the scope of this work to rewrite the mock server to use BinMsg instead of the legacy op codes. I can't find anything on Jira - do we have a ticket somewhere to update the mock server?

@nbbeeken
Copy link
Contributor Author

nbbeeken commented Dec 8, 2021

do we have a ticket somewhere to update the mock server?

@baileympearson
Our long term goal is to phase out use of it altogether, we now work only with server versions that have a wide array of failpoint features that should make the need of a mock server no longer necessary. So I'll actually make a ticket to track its removal 🙂
https://jira.mongodb.org/browse/NODE-3807

@dariakp dariakp merged commit f2dcc34 into main Dec 8, 2021
@dariakp dariakp deleted the chore/deps branch December 8, 2021 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants